Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize SystemTime::UNIX_EPOCH #51144

Merged
merged 1 commit into from
May 29, 2018
Merged

Stabilize SystemTime::UNIX_EPOCH #51144

merged 1 commit into from
May 29, 2018

Conversation

tmccombs
Copy link
Contributor

@tmccombs tmccombs commented May 29, 2018 •
edited by Mark-Simulacrum
Loading

Fixes #49502

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2018
@Mark-Simulacrum
Copy link
Member

Since FCP on the related tracking issue finished I believe we're clear to r+ this; cc @rust-lang/libs for any objections.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2018
@Mark-Simulacrum
Copy link
Member

...That was meant to be:

@bors r+

@bors
Copy link
Contributor

bors commented May 29, 2018

📌 Commit 855ec8b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2018
@bors
Copy link
Contributor

bors commented May 29, 2018

⌛ Testing commit 855ec8b with merge fe5c45b...

bors added a commit that referenced this pull request May 29, 2018
@bors
Auto merge of #51144 - tmccombs:unix-epoch-stable, r=Mark-Simulacrum
fe5c45b 
Stabilize SystemTime::UNIX_EPOCH

Fixes #49502
@bors
Copy link
Contributor

bors commented May 29, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing fe5c45b to master...

@bors bors merged commit 855ec8b into rust-lang:master May 29, 2018
ChristopherRabotin added a commit to nyx-space/hifitime that referenced this pull request May 29, 2018
@ChristopherRabotin
Added now() constructor in Instant. Requires nightly of 29 May 2018
6bf080e 
Yes, that's in the future. It was marked as stable for 1.28.0 about 11
minutes ago, cf. rust-lang/rust#51144 .
@tmccombs tmccombs deleted the unix-epoch-stable branch May 29, 2018 06:11
@newpavlov
Copy link
Contributor

Shouldn't it be in release notes?

@SimonSapin
Copy link
Contributor

Added in #52677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tmccombs @rust-highfive @Mark-Simulacrum @bors @newpavlov @SimonSapin @cramertj