Issue 50970 migration lint fq path

[nikomatsakis]

Similar issue, but for fully qualified paths.

Fixes #50970

r? @alexcrichton

[nikomatsakis]

whoops forgot about TODO. I'll fix tomorrow. I couldn't actually reproduce a bug here, so maybe it's fine as is, but it seems like this is wrong in some case or other and we should be tracking the root-id and root-path

[alexcrichton]

Hm so this may fall in this category?

#![crate_type = "rlib"]
#![feature(rust_2018_preview)]
#![warn(rust_2018_compatibility)]
#![allow(unused_imports, dead_code)]

mod foo {}
mod bar {}


fn main() {
    use {foo::{}, bar::{}};
}

Even with #50982 I think I'm still getting two warnings here

[nikomatsakis]

I fixed it in any case.

[nikomatsakis]

I found some other ways for it to go wrong, with a bit more effort =)

[rust-highfive]

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/a4/28/107c5a3a2552fc0bfb65b6a90bd37c1406755bedc019e532b2570d610913/awscli-1.15.26-py2.py3-none-any.whl (1.3MB)
    0% |▎                               | 10kB 14.0MB/s eta 0:00:01
    1% |▌                               | 20kB 1.9MB/s eta 0:00:01
    2% |▉                               | 30kB 2.2MB/s eta 0:00:01
    3% |█                               | 40kB 2.0MB/s eta 0:00:01
---

[00:04:33] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:33] tidy error: /checkout/src/librustc_resolve/lib.rs:2255: TODO is deprecated; use FIXME
[00:04:33] tidy error: /checkout/src/librustc_resolve/lib.rs:3291: line longer than 100 chars
[00:04:34] some tidy checks failed
[00:04:34] 
[00:04:34] 
[00:04:34] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:34] 
[00:04:34] 
[00:04:34] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:34] Build completed unsuccessfully in 0:01:47
[00:04:34] Build completed unsuccessfully in 0:01:47
[00:04:35] make: *** [tidy] Error 1
[00:04:35] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2176b238
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[rust-highfive]

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:04:31] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:31] tidy error: /checkout/src/librustc_resolve/lib.rs:3322: line longer than 100 chars
[00:04:32] some tidy checks failed
[00:04:32] 
[00:04:32] 
[00:04:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:32] 
[00:04:32] 
[00:04:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:32] Build completed unsuccessfully in 0:01:48
[00:04:32] Build completed unsuccessfully in 0:01:48
[00:04:32] make: *** [tidy] Error 1
[00:04:32] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:019b5068
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[alexcrichton]

@bors: r+ p=1

(higher priority for the edition preview)

[bors]

📌 Commit 688324e has been approved by alexcrichton

[bors]

⌛ Testing commit 688324e with merge 0eee99b8d752ddaccd999e9aadbd6d9945b7d4f2...

[bors]

💔 Test failed - status-travis

[rust-highfive]

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:06:00] [RUSTC-TIMING] syntax test:false 76.566
[00:06:00]    Compiling proc_macro v0.0.0 (file:///checkout/src/libproc_macro)
[00:06:18] [RUSTC-TIMING] proc_macro test:false 17.646
[00:06:18]    Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[rust-highfive]

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:06:00] [RUSTC-TIMING] syntax test:false 76.566
[00:06:00]    Compiling proc_macro v0.0.0 (file:///checkout/src/libproc_macro)
[00:06:18] [RUSTC-TIMING] proc_macro test:false 17.646
[00:06:18]    Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[alexcrichton]

@bors: retry

er... hanging in musl?

[bors]

⌛ Testing commit 688324e with merge 27649b7...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 27649b7 to master...