Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick refactoring around Substs & friends. #50801

Merged
merged 7 commits into from
May 21, 2018
Merged

Quick refactoring around Substs & friends. #50801

merged 7 commits into from
May 21, 2018

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented May 16, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 16, 2018

📌 Commit 5b4eaf5 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2018
@bors
Copy link
Contributor

bors commented May 17, 2018

☔ The latest upstream changes (presumably #50807) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 17, 2018
@eddyb
Copy link
Member Author

eddyb commented May 21, 2018

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented May 21, 2018

📌 Commit 73f6210 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2018
@bors
Copy link
Contributor

bors commented May 21, 2018

⌛ Testing commit 73f6210 with merge 56e541d...

bors added a commit that referenced this pull request May 21, 2018
@bors
Auto merge of #50801 - eddyb:param-things, r=nikomatsakis
56e541d 
Quick refactoring around Substs & friends.

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented May 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 56e541d to master...

@bors bors merged commit 73f6210 into rust-lang:master May 21, 2018
@eddyb eddyb deleted the param-things branch May 21, 2018 19:43
@mati865 mati865 mentioned this pull request May 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddyb @nikomatsakis @bors @rust-highfive