Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DebruijnIndex to be 0-based #50475

Merged
merged 13 commits into from
May 29, 2018
Merged

Refactor DebruijnIndex to be 0-based #50475

merged 13 commits into from
May 29, 2018

Commits on May 28, 2018

  1. introduce shifted_in, shifted_out and friends 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    69ab6f2 View commit details
    Browse the repository at this point in the history

  2. port fold_regions and friends to use debruijn indices directly 

    They no longer talk about plain integers.

Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    9c5a450 View commit details
    Browse the repository at this point in the history

  3. make shifted_in and shifted_out const fns 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    b5018de View commit details
    Browse the repository at this point in the history

  4. stop invoking DebruijnIndex::new directly 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    8bd4bff View commit details
    Browse the repository at this point in the history

  5. port nice_region_error code to not track depth but rather index 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    e2f7f4a View commit details
    Browse the repository at this point in the history

  6. rewrite the hasher to not access depth field 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    f965b79 View commit details
    Browse the repository at this point in the history

  7. refactor resolve_lifetime to track outer-index, not depth 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    34c9ae7 View commit details
    Browse the repository at this point in the history

  8. replace use of DebruijnIndex in for_each_free_region 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    4aeb6ef View commit details
    Browse the repository at this point in the history

  9. convert LateBoundRegionsCollector to track a debruijn index 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    06b2a3f View commit details
    Browse the repository at this point in the history

  10. replace binder_depth in LateBoundRegionsDetector 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    8f15d1e View commit details
    Browse the repository at this point in the history

  11. remove use of depth from TyS and replace with a debruijn index 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    7e15e0b View commit details
    Browse the repository at this point in the history

  12. make depth private 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    22a25d9 View commit details
    Browse the repository at this point in the history

  13. change to 0-based indices 

    Co-authored-by: csmoe <[email protected]>
    @nikomatsakis @csmoe
    nikomatsakis and csmoe committed May 28, 2018
    Configuration menu
    Copy the full SHA
    783fe4f View commit details
    Browse the repository at this point in the history