Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement label break value (RFC 2046) #50045

Merged
merged 9 commits into from
May 16, 2018
Merged

Implement label break value (RFC 2046) #50045

merged 9 commits into from
May 16, 2018

Commits on May 16, 2018

  1. label-break-value: Parsing and AST/HIR changes

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    11f5893 View commit details
    Browse the repository at this point in the history

  2. Add a file with test cases

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    ebca9c6 View commit details
    Browse the repository at this point in the history

  3. Make the compiler support the label-break-value feature 

    No error checking or feature gating yet
    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    5665980 View commit details
    Browse the repository at this point in the history

  4. Add E0695 for unlabeled breaks

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    63ef53f View commit details
    Browse the repository at this point in the history

  5. Extend error E0695 to unlabeled continue statements

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    50f063c View commit details
    Browse the repository at this point in the history

  6. Add E0696 for continue pointing to a labeled block

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    f8c2598 View commit details
    Browse the repository at this point in the history

  7. Test that label break value only works on actual blocks

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    128f2b5 View commit details
    Browse the repository at this point in the history

  8. Add feature gate label_break_value

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    dfa9831 View commit details
    Browse the repository at this point in the history

  9. Address review comments

    @est31
    est31 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    ae1553a View commit details
    Browse the repository at this point in the history