Fix regression in defaults #49344 #49704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@leodasvacas thanks for jumping on this! |
nikomatsakis
approved these changes
Apr 6, 2018
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 933f9eb has been approved by |
bors
added
the
S-waiting-on-bors
nikomatsakis
added
beta-nominated
Contributor
Author
|
This has indeed hit beta, we may consider backporting. |
Collaborator
bors
added a commit
that referenced
this pull request
Apr 8, 2018
Fix regression in defaults #49344 Fixes #49344 by not checking the well-formedness wrt defaults of predicates that contain lifetimes, which is consistent with not checking generic predicates. r? @nikomatsakis
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
kennytm
added
the
beta-accepted
bors
added a commit
that referenced
this pull request
Apr 14, 2018
[beta] Backport fix for regression in defaults This proposes a backport of #49704, which fixes a regression that affects beta. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49344 by not checking the well-formedness wrt defaults of predicates that contain lifetimes, which is consistent with not checking generic predicates.
r? @nikomatsakis