Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI job for parallel rustc using x.py check #49120

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Add a CI job for parallel rustc using x.py check #49120

merged 1 commit into from
Mar 24, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 17, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2018
@Zoxc Zoxc force-pushed the parallel-ci branch 2 times, most recently from 9ca0210 to 4bfb537 Compare March 17, 2018 21:49
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 17, 2018

It seems to take 3 minutes to check things. Maybe we could add it to PR builds too then?

@Mark-Simulacrum
Copy link
Member

76ce6e1 is probably not supposed to be in this PR.

I'm not entirely certain that I like this approach since it adds an extremely short CI builder.. I'm wondering if we can put this on top of some other builder instead, maybe via re-configuring mid run? I'm not sure how it would work, though.

@Zoxc Zoxc force-pushed the parallel-ci branch 3 times, most recently from 5582a51 to 906f51e Compare March 18, 2018 01:54
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 18, 2018

I moved it to the start of x86_64-gnu-debug, which is a fast job.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 18, 2018

📌 Commit 906f51e has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 18, 2018

@bors r-

This needs the fixes for Lrc, otherwise CI will just fail.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 18, 2018

It's probably a good idea to nuke the build directory after the first build too.

@Mark-Simulacrum
Copy link
Member

Hm, okay. I'd somewhat prefer to land those in a separate PR, but it does seem fine to include them here. Yes, we should probably go ahead and delete the build directory... ./x.py clean should be sufficient (though we might need to pass host/target flags).

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2018
@shepmaster
Copy link
Member

Ping from triage, @alexcrichton ! Looks like there have been some new commits pushed.

@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 23, 2018

This is just waiting on #49030 to land.

@shepmaster shepmaster added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 23, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Mar 23, 2018

📌 Commit efa9016 has been approved by alexcrichton

@bors bors removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Mar 23, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 23, 2018
@kennytm kennytm mentioned this pull request Mar 24, 2018
Closed
@bors
Copy link
Contributor

bors commented Mar 24, 2018

⌛ Testing commit efa9016 with merge 424d67bf95e422c922865ef623f017f043305f51...

@kennytm
Copy link
Member

kennytm commented Mar 24, 2018

@bors retry rollup

kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49120 - Zoxc:parallel-ci, r=alexcrichton
537f0d5 
 Add a CI job for parallel rustc using x.py check

r? @alexcrichton
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49120 - Zoxc:parallel-ci, r=alexcrichton
c5264a5 
 Add a CI job for parallel rustc using x.py check

r? @alexcrichton
@kennytm kennytm mentioned this pull request Mar 24, 2018
Merged
bors added a commit that referenced this pull request Mar 24, 2018
@bors
Auto merge of #49337 - kennytm:rollup, r=kennytm
f5631d9 
Rollup of 21 pull requests

- Successful merges: #49046, #49076, #49089, #49120, #49121, #49122, #49162, #49193, #49194, #49203, #49229, #49235, #49254, #49268, #49273, #49274, #49290, #49312, #49314, #49318, #49299
@bors bors merged commit efa9016 into rust-lang:master Mar 24, 2018
@Zoxc Zoxc deleted the parallel-ci branch March 24, 2018 21:53
@michaelwoerister michaelwoerister mentioned this pull request May 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zoxc @Mark-Simulacrum @alexcrichton @bors @shepmaster @kennytm @rust-highfive