Bring back ParamEnv deduplication #48576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Could we have a test for this? |
Contributor
Author
|
We probably should, but we don't have a deducted test case yet. |
Contributor
|
This seems to be causing a lot of pain, so I'm going to r+ with p=1, but I agree with @leodasvacas that we ought to have a test here. @bors r+ p=1 |
Collaborator
|
📌 Commit f297f56 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Feb 27, 2018
Bring back ParamEnv deduplication Fix #48551
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
Author
|
Initial simplified case: https://play.rust-lang.org/?gist=878f5427988c9c59b9ff11057547e624&version=stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #48551