Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pieces for sparc-linux-gnu support #48297

Merged
merged 4 commits into from
Feb 25, 2018

Conversation

glaubitz
Copy link
Contributor

I noticed that while Rust has CABI support for 32-bit SPARC, there are still some pieces missing to be able to use Rust on a 32-Bit SPARC system like Gentoo which still defaults to a 32-bit port unlike Debian's sparc64 port.

This PR is an attempt to add the missing pieces. I will send the necessary changes for libc in a separate PR.

CC @jrtc27

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2018
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 17, 2018

📌 Commit 5123547 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2018
@glaubitz
Copy link
Contributor Author

I have just updated that PR. I fixed two small issues (wrong name of the OpenSSL configuration and CPU name) and also added "sparc-unknown-linux-gnu" to tools/build-manifest/src/main.rs.

@glaubitz
Copy link
Contributor Author

@estebank Can you tell bors to pick the updated commits?

@sanxiyn
Copy link
Member

sanxiyn commented Feb 23, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2018

📌 Commit 8b5dab0 has been approved by sanxiyn

@glaubitz
Copy link
Contributor Author

@sanxiyn Sorry, I just noticed that I forgot to add sparc-unknown-linux-gnu to src/librustc_back/target/mod.rs. Could you re-approve?

@sanxiyn
Copy link
Member

sanxiyn commented Feb 23, 2018

Sure. @bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2018

📌 Commit a3b1a0b has been approved by sanxiyn

@glaubitz glaubitz force-pushed the sparc-linux branch 2 times, most recently from b326273 to 283626f Compare February 23, 2018 16:53
@glaubitz
Copy link
Contributor Author

glaubitz commented Feb 23, 2018

@sanxiyn Ok, one more :). We decided to pass "-mv8plus" to the linker which is useful when cross-building.

The rest is fine now, we rechecked all bits and pieces.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2018

📌 Commit 84aae4e has been approved by estebank

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 25, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 25, 2018
Add missing pieces for sparc-linux-gnu support

I noticed that while Rust has CABI support for 32-bit SPARC, there are still some pieces missing to be able to use Rust on a 32-Bit SPARC system like Gentoo which still defaults to a 32-bit port unlike Debian's sparc64 port.

This PR is an attempt to add the missing pieces. I will send the necessary changes for libc in a separate PR.

CC @jrtc27
bors added a commit that referenced this pull request Feb 25, 2018
Rollup of 17 pull requests

- Successful merges: #47964, #47970, #48076, #48115, #48166, #48281, #48297, #48302, #48362, #48369, #48489, #48491, #48494, #48517, #48529, #48235, #48330
- Failed merges:
@bors bors merged commit 84aae4e into rust-lang:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants