Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize Unsafe Pointer Methods #48259

Merged
merged 1 commit into from
Mar 3, 2018
Merged

Stabilize Unsafe Pointer Methods #48259

merged 1 commit into from
Mar 3, 2018

Conversation

tinaun
Copy link
Contributor

@tinaun tinaun commented Feb 16, 2018

also minor doc fixes.

Closes #43941

@rust-highfive
Copy link
Collaborator

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2018
@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Feb 16, 2018
@arazabishov
Copy link
Member

Ping from triage @Kimundi :) Did you have a chance to take a look on this PR?

@shepmaster
Copy link
Member

Ping from triage @rust-lang/libs ! We haven't heard from @Kimundi in a while, would you assign a new reviewer?

@alexcrichton
Copy link
Member

Thanks for the PR @tinaun and sorry for the delay! It looks like there's a tidy error on travis but other than that looks good to me, I can r+ once the error is fixed up

@alexcrichton alexcrichton assigned alexcrichton and unassigned Kimundi Mar 2, 2018
@shepmaster shepmaster added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2018
@tinaun
Copy link
Contributor Author

tinaun commented Mar 3, 2018

unless travis finds anything else this should be good

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 3, 2018

📌 Commit 1011b8a has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2018
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 3, 2018
@Manishearth
Rollup merge of rust-lang#48259 - tinaun:patch-1, r=alexcrichton
65253fd 
Fixes rust-lang#47311.
r? @nrc
@bors bors merged commit 1011b8a into rust-lang:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for Unsafe Pointer Methods reform
8 participants
@tinaun @rust-highfive @arazabishov @shepmaster @alexcrichton @bors @Centril @Kimundi