Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the run-make tests last, so more tests run on Windows when make is unavailable #47996

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Feb 4, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2018
@Mark-Simulacrum
Copy link
Member

It seems like instead of doing this, we should make make a required thing to find and add it to the sanity checks rustbuild does, so that we fail early if it's not available. We've also somewhat long wanted to move these away from make too: #40713.

However, this change does seem minimally useful, so @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 4, 2018

📌 Commit 32d5fbe has been approved by Mark-Simulacrum

kennytm added a commit to kennytm/rust that referenced this pull request Feb 4, 2018
Run the `run-make` tests last, so more tests run on Windows when `make` is unavailable
bors added a commit that referenced this pull request Feb 4, 2018
Rollup of 10 pull requests

- Successful merges: #47862, #47877, #47896, #47912, #47947, #47958, #47978, #47996, #47999, #47892
- Failed merges:
bors added a commit that referenced this pull request Feb 4, 2018
Rollup of 10 pull requests

- Successful merges: #47862, #47877, #47896, #47912, #47947, #47958, #47978, #47996, #47999, #47892
- Failed merges:
@retep998
Copy link
Member

retep998 commented Feb 4, 2018

It seems like instead of doing this, we should make make a required thing to find and add it to the sanity checks rustbuild does, so that we fail early if it's not available.

That would go completely against the point of this PR which is to enable developers without make to be able to run as many tests as possible. Having an early sanity check that stops them from running any tests would render those developers unable to test their changes locally.

@Mark-Simulacrum
Copy link
Member

That's true. We can also disable run-make tests if we don't detect a make, something I believe we do for some of the other tools. Anyway, not too important I think.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2018
@bors bors merged commit 32d5fbe into rust-lang:master Feb 5, 2018
@Zoxc Zoxc deleted the run-make-last branch March 3, 2018 06:38
kennytm added a commit to kennytm/rust that referenced this pull request Mar 21, 2018
Run the `run-make` tests last, so more tests run on Windows when `make` is unavailable

Just rust-lang#47996 again.

r? @Mark-Simulacrum
kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018
Run the `run-make` tests last, so more tests run on Windows when `make` is unavailable

Just rust-lang#47996 again.

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants