-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type filter in rustdoc js #46672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also on beta. Can this and related PRs fixing the new search be backported before the next stable? |
kennytm
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 12, 2017
I suppose? First, it needs to be merged anyway. |
@bors r+ rollup |
📌 Commit 557236c has been approved by |
kennytm
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 12, 2017
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 12, 2017
…ch, r=QuietMisdreavus Fix type filter in rustdoc js Fixes rust-lang#46612. r? @QuietMisdreavus
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 12, 2017
…ch, r=QuietMisdreavus Fix type filter in rustdoc js Fixes rust-lang#46612. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Dec 23, 2017
[beta] Doc search backports This is a backport of #46081, #46175, #46433, and #46672. They all merged cleanly but I haven't tried a build; let's see what Travis says. These PRs fix pretty annoying issues with doc search and so I think it's important they don't slip to stable, but these PRs have *NOT* been `beta-accepted` yet. cc @steveklabnik @GuillaumeGomez can you tag the docs team to talk about beta-acceptance?
Looks like we forgot to backport this for 1.23.0 (sorry about that!) so removing beta tags. |
alexcrichton
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Jan 10, 2018
Er sorry, looks like this was backported in #46886 |
alexcrichton
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46612.
r? @QuietMisdreavus