Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type filter in rustdoc js #46672

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

GuillaumeGomez
Copy link
Member

@durka
Copy link
Contributor

durka commented Dec 12, 2017

This is also on beta. Can this and related PRs fixing the new search be backported before the next stable?

@kennytm kennytm added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2017
@GuillaumeGomez
Copy link
Member Author

I suppose? First, it needs to be merged anyway.

@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 12, 2017

📌 Commit 557236c has been approved by QuietMisdreavus

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 12, 2017
…ch, r=QuietMisdreavus

Fix type filter in rustdoc js

Fixes rust-lang#46612.

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this pull request Dec 12, 2017
…ch, r=QuietMisdreavus

Fix type filter in rustdoc js

Fixes rust-lang#46612.

r? @QuietMisdreavus
bors added a commit that referenced this pull request Dec 12, 2017
Rollup of 4 pull requests

- Successful merges: #46668, #46672, #46691, #46694
- Failed merges:
@bors bors merged commit 557236c into rust-lang:master Dec 12, 2017
@GuillaumeGomez GuillaumeGomez deleted the fix-type-filter-search branch December 13, 2017 09:19
bors added a commit that referenced this pull request Dec 23, 2017
[beta] Doc search backports

This is a backport of #46081, #46175, #46433, and #46672. They all merged cleanly but I haven't tried a build; let's see what Travis says.

These PRs fix pretty annoying issues with doc search and so I think it's important they don't slip to stable, but these PRs have *NOT* been `beta-accepted` yet.

cc @steveklabnik @GuillaumeGomez can you tag the docs team to talk about beta-acceptance?
@alexcrichton
Copy link
Member

Looks like we forgot to backport this for 1.23.0 (sorry about that!) so removing beta tags.

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 10, 2018
@alexcrichton
Copy link
Member

Er sorry, looks like this was backported in #46886

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants