Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_mir: don't move temporaries that are still used later. #46492

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Dec 4, 2017

This should unbreak using the MIR borrow-checker on libcore (assuming #46268 is merged).

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 4, 2017
@nikomatsakis
Copy link
Contributor

r=me if we still want this

@nikomatsakis
Copy link
Contributor

Note however travis failures.

@nikomatsakis
Copy link
Contributor

Also, test?

@eddyb eddyb removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 4, 2017
@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 5, 2017
@eddyb
Copy link
Member Author

eddyb commented Dec 5, 2017

r? @arielb1

@rust-highfive rust-highfive assigned arielb1 and unassigned nikomatsakis Dec 5, 2017
@arielb1
Copy link
Contributor

arielb1 commented Dec 5, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Dec 5, 2017

📌 Commit 2a629f9 has been approved by arielb1

@bors
Copy link
Contributor

bors commented Dec 5, 2017

⌛ Testing commit 2a629f9 with merge bf2be61...

bors added a commit that referenced this pull request Dec 5, 2017
rustc_mir: don't move temporaries that are still used later.

This should unbreak using the MIR borrow-checker on `libcore` (assuming #46268 is merged).
@bors
Copy link
Contributor

bors commented Dec 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing bf2be61 to master...

@bors bors merged commit 2a629f9 into rust-lang:master Dec 5, 2017
@eddyb eddyb deleted the move-ops branch December 5, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants