Update reference link in doc's 404 #45778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently linking to a page that says it's on the page I'm changing the link too.
|
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
|
Good catch! r=me pending travis. (EDIT: though i'm not sure if linkchecker goes through all these pages? eh, habit *shrug*) |
kennytm
added
the
S-waiting-on-bors
|
@bors r=QuietMisdreavus rollup |
|
📌 Commit 6363b06 has been approved by |
steveklabnik
approved these changes
Nov 5, 2017
|
@bors: r+ rollup thanks! i wonder why linkchecker isn't run here... |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 6363b06 has been approved by |
|
I don't think the linkchecker can verify if an external link is valid... |
|
The prior link is still valid insomuch as there's a page there. It's just not a useful page. |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 7, 2017
Update reference link in doc's 404 It's currently linking to a page that says it's on the page I'm changing the link too.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 7, 2017
Update reference link in doc's 404 It's currently linking to a page that says it's on the page I'm changing the link too.
bors
added a commit
that referenced
this pull request
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently linking to a page that says it's on the page I'm changing the link too.