relaunch RangeBounds
#44518
relaunch RangeBounds
#44518
Conversation
arielb1
added
the
S-waiting-on-author
`Bound` is exported as `std::ops::Bound` and `alloc::Bound`, cann't use an uniform relative path to link `BTreeMap` from here.
|
Thanks for updating this! @bors r+ |
|
📌 Commit 723b069 has been approved by |
| is_sync_send!(BTreeMap::<usize, usize>::new(), range((Included(&0), Included(&9)))); | ||
| is_sync_send!(BTreeMap::<usize, usize>::new(), range_mut((Included(&0), Included(&9)))); | ||
| is_sync_send!(BTreeMap::<usize, usize>::new(), range((Included(0), Included(9)))); | ||
| is_sync_send!(BTreeMap::<usize, usize>::new(), range_mut((Included(0), Included(9)))); |
There was a problem hiding this comment.
Was this change required to get this compiling? If so this may be a breaking change?
| pub fn range<T: ?Sized, R>(&self, range: R) -> Range<K, V> | ||
| where T: Ord, K: Borrow<T>, R: RangeArgument<T> | ||
| pub fn range<T, R>(&self, range: R) -> Range<K, V> | ||
| where T: Ord, K: Borrow<T>, R: Into<RangeBounds<T>> |
There was a problem hiding this comment.
Shouldn't this be RangeBounds<&T>?
There was a problem hiding this comment.
So I actually recall this being one of the things I struggled with making the original PR. This prevents things like "a".to_string()..="z".to_string(). Because Borrow works differently from AsRef, this prevents both String ranges and str ranges from working properly.
There may be a way to make it work but I was really stumped in the original PR and got busy and didn't pick it back up.
|
@bors r- |
|
☔ The latest upstream changes (presumably #44678) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ping @liigo, just want to make sure this doesn't fall off your radar! |
|
Ok I'm going to close this due to inactivity, but feel free to resubmit @liigo! |
|
I'd really like to get this stabilized so if @liigo isn't available to di it, I'll gladly do it. |
based on PR #43033 (by @clarcharr ) which is out of time for a bit long time
r? @sfackler or @alexcrichton