Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an example for std::str::into_boxed_bytes() #44485

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Added an example for std::str::into_boxed_bytes() #44485

merged 2 commits into from
Sep 15, 2017

Conversation

42triangles
Copy link

This solves issue #44423.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents
Copy link
Member

r? @frewsxcv

Thank you for the PR! ❤️

@rust-highfive rust-highfive assigned frewsxcv and unassigned dtolnay Sep 11, 2017
@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2017
@frewsxcv
Copy link
Member

thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 11, 2017

📌 Commit f452acb has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 13, 2017
@GuillaumeGomez
Rollup merge of rust-lang#44485 - 42triangles:master, r=frewsxcv
b964209 
Added an example for `std::str::into_boxed_bytes()`

This solves issue rust-lang#44423.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 13, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 14, 2017
@frewsxcv
Rollup merge of rust-lang#44485 - 42triangles:master, r=frewsxcv
f90eabd 
Added an example for `std::str::into_boxed_bytes()`

This solves issue rust-lang#44423.
@frewsxcv frewsxcv mentioned this pull request Sep 14, 2017
Closed
@alexcrichton alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017
@frewsxcv
Rollup merge of rust-lang#44485 - 42triangles:master, r=frewsxcv
e3c4b8c 
Added an example for `std::str::into_boxed_bytes()`

This solves issue rust-lang#44423.
@frewsxcv frewsxcv mentioned this pull request Sep 15, 2017
Merged
bors added a commit that referenced this pull request Sep 15, 2017
@bors
Auto merge of #44585 - frewsxcv:rollup, r=frewsxcv
d86a7f7 
Rollup of 23 pull requests

- Successful merges: #44131, #44254, #44368, #44374, #44378, #44388, #44430, #44450, #44453, #44472, #44476, #44477, #44485, #44497, #44521, #44534, #44536, #44541, #44552, #44559, #44563, #44569, #44572
- Failed merges:
@bors bors merged commit f452acb into rust-lang:master Sep 15, 2017
@frewsxcv frewsxcv mentioned this pull request Sep 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@42triangles @rust-highfive @carols10cents @frewsxcv @bors @alexcrichton @dtolnay @CodenameLambda