Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0106: field lifetimes #43912

Merged
merged 2 commits into from
Aug 17, 2017
Merged

E0106: field lifetimes #43912

merged 2 commits into from
Aug 17, 2017

Conversation

Songbird0
Copy link
Contributor

@Songbird0 Songbird0 commented Aug 16, 2017

Hi there,

I've added an example for custom type lifetimes located in another struct field.

cc @GuillaumeGomez

I've added an example for custom type lifetimes located in another `struct` fields.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -362,6 +362,10 @@ Here are some simple examples of where you'll run into this error:
struct Foo { x: &bool } // error
struct Foo<'a> { x: &'a bool } // correct

struct Bar{ x: Foo }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a whitespace before a {.

@@ -362,6 +362,10 @@ Here are some simple examples of where you'll run into this error:
struct Foo { x: &bool } // error
struct Foo<'a> { x: &'a bool } // correct

struct Bar{ x: Foo }
^^^ expected lifetime parameter
struct Bar<'a>{ x: Foo<'a> } // correct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@GuillaumeGomez
Copy link
Member

Once this fixed, it'll be good. Thanks for your contribution!

@aidanhs aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 16, 2017
@Songbird0
Copy link
Contributor Author

Done!

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 17, 2017

📌 Commit d6cdefc has been approved by GuillaumeGomez

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 17, 2017
…GuillaumeGomez

E0106: field lifetimes

Hi there,

I've added an example for custom type lifetimes located in another `struct` field.

cc @GuillaumeGomez
bors added a commit that referenced this pull request Aug 17, 2017
Rollup of 9 pull requests

- Successful merges: #43891, #43905, #43912, #43914, #43915, #43916, #43920, #43928, #43930
- Failed merges:
@bors bors merged commit d6cdefc into rust-lang:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants