-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP implement a machine readable print-type-info API #43761
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #42932) made this pull request unmergeable. Please resolve the merge conflicts. |
What's the status of this PR? Do you need any help (I won't be available until this Monday)? |
Hey @arielb1 sorry I pivoted off this a bit and then went on vacation. Tomorrow I get back to work and, unless I get some information stating otherwise, this should be my top priority. |
Hi @gankro are you still working on this? Just a ping to make sure it isn't getting lost. |
Hiii Ganksy, triage procedure says a PR with >14 days of no author activity gets closed as inactive. Feel free to reopen when you have a chance to get back to this! |
Yeah I'll get back to this once I've got all the fires in webrender put out! |
I have a branch in progress which if I get out soon would provide a much better baseline for this. |
(continuing this work is blocked on that PR) |
@gankro Given that the referenced PR was merged couple of months ago, are there any other blockers for this one left? (apart from free time, of course 😄 ) |
My enum RFC combined with cbindgen relieves a lot of pressure on this, and i'm recovering on indeterminate-length leave right now, so if you're interested I suggest taking this over. |
This is very messy, with some commented out stuff and some TODOs. I'm posting this now to get feedback on the approach, and so someone can tell me where stuff should go or if I'm doing some things fundamentally wrong. Note that I'm currently clobbering
-Zprint-type-sizes
to avoid doing driver plumbing atm.Background Proposal (doesn't completely match impl, see below)
Draft Documentation
Sample output on gecko/gfx/webrender_bindings
Differences from background proposal:
TODO
-Zprint-type-sizes