add a built-in MSP430 target #43099
add a built-in MSP430 target #43099
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit fc0275a has been approved by |
shepmaster
added
the
S-waiting-on-bors
add a built-in MSP430 target the MSP430 backend has been enabled for a while but no target was added to rustc to encourage out of tree experimentation. We believe the out of tree (custom) target has been iterated long enough and is stable enough for inclusion in the compiler. Kudos to @pftbest and @awygle for fixing several LLVM / codegen bugs this target had! The target name chosen is a slight variation of the triple gcc uses, which is simply `msp430-elf`. We picked `msp430-none-elf` to leave room for custom targets that target some embedded OS running on MSP430 devices. (cf. the custom `thumbv7m-tockos-eabi` target TockOS uses vs the built-in `thumbv7m-none-eabi`). There's one expected change in the specification of the proposed target: the `asm_args` and `no_integrated_as` fields will change to their default values. Once the LLVM backend gains the ability to directly produce MSP430 object files we can stop depending on `msp430-elf-gcc` for producing object files; when that occurs the `asm` related fields will change. This change won't break existing user code. r? @alexcrichton cc @brson
|
☀️ Test successful - status-appveyor, status-travis |
|
@alexcrichton Should |
the MSP430 backend has been enabled for a while but no target was added to rustc
to encourage out of tree experimentation.
We believe the out of tree (custom) target has been iterated long enough and is
stable enough for inclusion in the compiler. Kudos to @pftbest and @awygle for
fixing several LLVM / codegen bugs this target had!
The target name chosen is a slight variation of the triple gcc uses, which is
simply
msp430-elf. We pickedmsp430-none-elfto leave room for customtargets that target some embedded OS running on MSP430 devices. (cf. the
custom
thumbv7m-tockos-eabitarget TockOS uses vs the built-inthumbv7m-none-eabi).There's one expected change in the specification of the proposed target: the
asm_argsandno_integrated_asfields will change to their default values.Once the LLVM backend gains the ability to directly produce MSP430 object files
we can stop depending on
msp430-elf-gccfor producing object files; when thatoccurs the
asmrelated fields will change. This change won't break existinguser code.
r? @alexcrichton
cc @brson