-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E0602 #42361
Add E0602 #42361
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
So you're making the command-line lint and the lint attribute errors separate errors then? Is this formatting in line when rustc emits errors for other command-line arguments? I wouldn't expect error numbers for command-line parsing issues, just for code-related errors (like the lint attribute error). |
EDIT: you saw nothing |
LOL. Glad that got sorted (don't worry, I have email proof!) ✉️ |
Yep, I still need to add the "code lint" error code, but it seems more logical for me in order to make better error explanation. |
b56c0db
to
7cc1ab4
Compare
Sure, adding more details wouldn't be a bad thing. I think it's unnecessary, but I don't think it'd hurt for users not very comfortable at the command line (and general argument syntax). Two questions:
|
The lint name is given iirc. And I don't think giving the full lint name list is a good idea since it's getting quite long. ;) |
Adding levenshtein-based suggestions would be nice, but I think it's a little bit to much. @bors r+ |
📌 Commit 7cc1ab4 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Part of #42229.
cc @Susurrus