Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression test for #38821 #42160

Merged
merged 1 commit into from
May 23, 2017
Merged

regression test for #38821 #42160

merged 1 commit into from
May 23, 2017

Conversation

venkatagiri
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 22, 2017

📌 Commit d2ef70f has been approved by Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

Thanks! There's a bunch more similar issues (Fixed ICEs) that you could take on if you want.

@venkatagiri
Copy link
Contributor Author

I will take a look at those issues.
BTW, there was a typo in the file name for this test.
isssue instead of issue. Should I fix this, re-base and push the fix? Or should I close this one and open another PR?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 23, 2017
@frewsxcv
Rollup merge of rust-lang#42160 - venkatagiri:issue_38821, r=Mark-Sim…
f37b34d 
…ulacrum

regression test for rust-lang#38821

Closes rust-lang#38821

r? @Mark-Simulacrum
@frewsxcv frewsxcv mentioned this pull request May 23, 2017
Merged
bors added a commit that referenced this pull request May 23, 2017
@bors
Auto merge of #42165 - frewsxcv:rollup, r=frewsxcv
852b7cb 
Rollup of 8 pull requests

- Successful merges: #42016, #42122, #42144, #42145, #42151, #42152, #42160, #42163
- Failed merges:
@bors bors merged commit d2ef70f into rust-lang:master May 23, 2017
@venkatagiri venkatagiri deleted the issue_38821 branch May 25, 2017 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@venkatagiri @rust-highfive @Mark-Simulacrum @bors