Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention Vec::into_boxed_slice in documentation of [T]::into_vec #42151

Merged
merged 2 commits into from
May 23, 2017
Merged

Mention Vec::into_boxed_slice in documentation of [T]::into_vec #42151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78bdda1
Mention Vec::into_boxed_slice in docs for [T]::into_vec.
Wallacoloo May 22, 2017
6e8e5c9
Slice::into_vec: Don't link to Vec::into_boxed_slice
Wallacoloo May 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libcollections/slice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,6 +1410,11 @@ impl<T> [T] {

/// Converts `self` into a vector without clones or allocation.
///
/// The resulting vector can be converted back into a box via
/// the [`into_boxed_slice`] method.
///
/// [`into_boxed_slice`]: vec/struct.Vec.html#method.into_boxed_slice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, I have a feeling this link won't work because this method appears on both the slice and Vec doc pages. as is, the link works on the slice page, but on the vec page, it would end up linking to std/vec/vec/struct.Vec.html#method.into_vec. we'll find out soon whether this passes the linkchecker on Travis CI, but i'm guessing this link will probably need to be removed

///
/// # Examples
///
/// ```
Expand Down