appveyor: Wrap handle.exe download in a retry

[alexcrichton]

Should help deal with spurious download failures.

[rust-highfive]

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit e5ec073 has been approved by Mark-Simulacrum

[Mark-Simulacrum]

@bors p=20

We keep hitting this...

[bors]

⌛ Testing commit e5ec073 with merge 8f01693...

[bors]

💔 Test failed - status-appveyor

[Mark-Simulacrum]

I guess we failed to retry? After 3 hours of retrying? This seems suspicious..

https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3252/job/s26dwj5huwd7x8fs

@bors retry

• Tracking issue for spurious network failures on bots #40474

00:00:39] Added C:\ProgramData\chocolatey\bin\ISCC.exe shim pointed to 'c:\program files (x86)\inno setup 5\iscc.exe'.
[00:00:39]  The install of innosetup was successful.
[00:00:39]   Software installed as 'exe', install location is likely default.
[00:00:39]
[00:00:39] Chocolatey installed 2/2 packages. 0 packages failed.
[00:00:39]  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
[00:00:39] set PATH="C:\Program Files (x86)\Inno Setup 5";%PATH%
[00:00:39] appveyor-retry appveyor DownloadFile https://download.sysinternals.com/files/Handle.zip

[ishitatsuyuki]

Time to mirror it. It may just being the network hanging.

[bors]

⌛ Testing commit e5ec073 with merge 372c218...

[bors]

💔 Test failed - status-appveyor

[Mark-Simulacrum]

Downloading Handle.zip (316,667 bytes)...6% Progress!

@bors retry

• Tracking issue for spurious network failures on bots #40474

[ishitatsuyuki]

@Mark-Simulacrum I'd rather recommend to calm down and fix this to use a mirror. I have no idea who has access to S3, but I guess it's not only granted to Alex. You should also be able modify the commit in that case.

[bors]

⌛ Testing commit e5ec073 with merge bfeb076...

[bors]

💔 Test failed - status-travis

[kennytm]

Travis:

[01:29:00] error: unable to get packages from source
[01:29:00] 
[01:29:00] Caused by:
[01:29:00]   failed to get 200 response from `https://crates.io/api/v1/crates/utf8-ranges/0.1.3/download`, got 500

I thought it was fixed in #41978? And utf8-ranges again?

[alexcrichton]

@bors: retry

• Tracking issue for spurious network failures on bots #40474

[alexcrichton]

@kennytm no the bootstrap won't use that Cargo until the next beta happens.

[bors]

⌛ Testing commit e5ec073 with merge 4565e1d...

[frewsxcv]

Even with this change, AppVeyor still ran into an issue downloading handle.exe:

https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3261/job/hgnbayocfa0rvkis

[alexcrichton]

@bors: r=Mark-Simulacrum

I've updated to a mirror

[bors]

📌 Commit 7644508 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 7644508 with merge 0cbc437...

[bors]

💔 Test failed - status-travis

[frewsxcv]

that's gotta be unrelated, but what exactly is the error there?

@bors retry

[bors]

⌛ Testing commit 7644508 with merge 9f3ba8b...

[Mark-Simulacrum]

Yeah, I guess... rustc hung? It's odd.

[alexcrichton]

From the previous successful build:

[00:09:29]    Compiling rustc v0.0.0 (file:///checkout/src/librustc)
[00:13:25]    Compiling rustc_incremental v0.0.0 (file:///checkout/src/librustc_incremental)

Not sure how this jumped from 4 minutes to >30 in one run...

[bors]

💔 Test failed - status-travis

[alexcrichton]

@bors: retry

• travis deployment problem?

[bors]

⌛ Testing commit 7644508 with merge ae33d99...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing ae33d99 to master...