Unignore android for previously spuriously failing test. #41618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will see if this start failing again, in which case we'll re-ignore the test.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Let's give it a shot! A bunch has changed since then... @bors: r+ rollup |
|
📌 Commit bd4191d has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 29, 2017
…turon Unignore android for previously spuriously failing test. Will see if this start failing again, in which case we'll re-ignore the test. In theory, rust-lang#20004 could be fixed by this. I've left that open because it's possible that this will resume the previous spurious failures, and marked it as A-spurious so people doing PR triage catch that. I will leave a comment there saying that if we see failures from this test on android, we should re-ignore it.
|
@bors r- this still fails https://travis-ci.org/rust-lang/rust/jobs/227204034 |
|
Ah. Unfortunate. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will see if this start failing again, in which case we'll re-ignore the test.
In theory, #20004 could be fixed by this. I've left that open because it's possible that this will resume the previous spurious failures, and marked it as A-spurious so people doing PR triage catch that. I will leave a comment there saying that if we see failures from this test on android, we should re-ignore it.