Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associated consts are not object safe. #41494

Merged

Conversation

withoutboats
Copy link
Contributor

@withoutboats withoutboats commented Apr 24, 2017

fixes #26847

r? @eddyb

@withoutboats
Copy link
Contributor Author

added compile-fail test

fn make_bar<T:Bar>(t: &T) -> &Bar {
//~^ ERROR E0038
//~| NOTE the trait cannot contain associated consts like `X`
//~| NOTE the trait `Bar` cannot be made into an object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessarily indented once to the right.

@arielb1
Copy link
Contributor

arielb1 commented Apr 24, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2017

📌 Commit 95ffda1 has been approved by arielb1

@bors
Copy link
Contributor

bors commented Apr 24, 2017

⌛ Testing commit 95ffda1 with merge 4f43c84...

bors added a commit that referenced this pull request Apr 24, 2017
…safe, r=arielb1

Associated consts are not object safe.

r? @eddyb
@withoutboats withoutboats changed the title Associated consts are not object safe. Associated consts are not object safe. fixes #26847 Apr 24, 2017
@withoutboats withoutboats changed the title Associated consts are not object safe. fixes #26847 Associated consts are not object safe. Apr 24, 2017
@bors
Copy link
Contributor

bors commented Apr 24, 2017

💔 Test failed - status-travis

@eddyb
Copy link
Member

eddyb commented Apr 24, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2017

📌 Commit 5dc43d2 has been approved by eddyb

@bors
Copy link
Contributor

bors commented Apr 24, 2017

⌛ Testing commit 5dc43d2 with merge 846891a...

bors added a commit that referenced this pull request Apr 24, 2017
…safe, r=eddyb

Associated consts are not object safe.

fixes #26847

r? @eddyb
@bors
Copy link
Contributor

bors commented Apr 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 846891a to master...

@bors bors merged commit 5dc43d2 into rust-lang:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associated constants should not be object safe
4 participants