Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic documentation/examples for six unstable features. #40452

Merged
merged 6 commits into from
Mar 17, 2017
Merged

Add basic documentation/examples for six unstable features. #40452

merged 6 commits into from
Mar 17, 2017

Conversation

frewsxcv
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv force-pushed the frewsxcv-unstable-docs branch 2 times, most recently from c3be18e to aa25229 Compare March 12, 2017 06:18
@frewsxcv frewsxcv changed the title Add documentation for six unstable features. Add basic documentation/examples for six unstable features. Mar 12, 2017
JordiPolo
JordiPolo reviewed Mar 12, 2017
View reviewed changes
src/doc/unstable-book/src/conservative-impl-trait.md Outdated
@@ -6,5 +6,19 @@ The tracking issue for this feature is: [#34511]

------------------------

The `conservative_impl_trait` feature allows a conservative form of abstract return types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because I'm new to the language, but this does not make it clearer to me. The example also does not make me understand why regular stable Rust would not behave this way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @JordiPolo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest force push expands this section. Most of the copy is from the associated RFC.

GuillaumeGomez
GuillaumeGomez reviewed Mar 12, 2017
View reviewed changes
src/doc/unstable-book/src/conservative-impl-trait.md Outdated

```rust
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to precise rust in the book?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure.

@frewsxcv frewsxcv force-pushed the frewsxcv-unstable-docs branch 3 times, most recently from 7b28c3c to cc2e700 Compare March 12, 2017 20:32
@GuillaumeGomez
Copy link
Member

Good for me, thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 13, 2017

📌 Commit cc2e700 has been approved by GuillaumeGomez

steveklabnik
steveklabnik previously requested changes Mar 13, 2017
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors: r-

could you word wrap everything please?

src/doc/unstable-book/src/conservative-impl-trait.md Outdated

Abstract return types allow a function to hide a concrete return type behind a trait interface similar to trait objects, while still generating the same statically dispatched code as with concrete types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't wrapped

@steveklabnik
Copy link
Member

@bors: r-

@frewsxcv
Copy link
Member Author

could you word wrap everything please?

Is our policy on word wrapping / line length documented somewhere?

@frewsxcv frewsxcv dismissed steveklabnik’s stale review March 14, 2017 01:39

Wrapped everything at 80 columns.

@frewsxcv
Copy link
Member Author

I wrapped everything and didn't change anything else, so I'm just going to re-approve this

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit d3ae2eb has been approved by GuillaumeGomez

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 15, 2017
@frewsxcv
Rollup merge of rust-lang#40452 - frewsxcv:frewsxcv-unstable-docs, r=…
c4db59f 
…GuillaumeGomez

Add basic documentation/examples for six unstable features.
@frewsxcv frewsxcv mentioned this pull request Mar 15, 2017
Closed
bors added a commit that referenced this pull request Mar 15, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
b5ccda0 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
bors added a commit that referenced this pull request Mar 16, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
d62dea5 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40452 - frewsxcv:frewsxcv-unstable-docs, r=…
ca39ff6 
…GuillaumeGomez

Add basic documentation/examples for six unstable features.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40452 - frewsxcv:frewsxcv-unstable-docs, r=…
027aa1e 
…GuillaumeGomez

Add basic documentation/examples for six unstable features.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40452 - frewsxcv:frewsxcv-unstable-docs, r=…
fefd84e 
…GuillaumeGomez

Add basic documentation/examples for six unstable features.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40452 - frewsxcv:frewsxcv-unstable-docs, r=…
74a7b4a 
…GuillaumeGomez

Add basic documentation/examples for six unstable features.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40452 - frewsxcv:frewsxcv-unstable-docs, r=…
739d89a 
…GuillaumeGomez

Add basic documentation/examples for six unstable features.
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Merged
bors added a commit that referenced this pull request Mar 17, 2017
@bors
Auto merge of #40598 - frewsxcv:rollup, r=frewsxcv
a559452 
Rollup of 23 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40458, #40463, #40466, #40467, #40495, #40496, #40497, #40499, #40500, #40503, #40505, #40512, #40514, #40517, #40520, #40536, #40545, #40586
- Failed merges:
@bors bors merged commit d3ae2eb into rust-lang:master Mar 17, 2017
@frewsxcv frewsxcv deleted the frewsxcv-unstable-docs branch March 18, 2017 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordiPolo JordiPolo JordiPolo left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@steveklabnik steveklabnik steveklabnik left review comments

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frewsxcv @rust-highfive @GuillaumeGomez @bors @steveklabnik @JordiPolo