When compiletest'ing src/test/mir-opt, check timestamps. #39717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@pnkfelix due to our vendoring requirements it'll be easiest to avoid the addition of the |
Ugh, seconds from the epoch is so ugly. I'll just leave the timestamps out of the |
pnkfelix
force-pushed
the
check-timestamps-in-compiletest-miropt
branch
from
eac3f68 to
ca94a64
Compare
pnkfelix
force-pushed
the
check-timestamps-in-compiletest-miropt
branch
from
8055031 to
67971e4
Compare
This version removes prior use of `time` crate, to satisify vendoring requirements. remove extraneous whitespace change
pnkfelix
force-pushed
the
check-timestamps-in-compiletest-miropt
branch
from
67971e4 to
6a78282
Compare
|
@bors: r+ |
|
📌 Commit 6a78282 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 20, 2017
…t, r=alexcrichton When compiletest'ing src/test/mir-opt, check timestamps. The tests in src/test/mir-opt embed references to generated files. The names of the generated files embed node id's, which will change depending on the content of the original source. To guard against comparisons against stale output, check the timestamps of the supposed output against the timestamp of the original source (i.e. any output should be at least as new as the source that was recompiled). Fix #39690.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in src/test/mir-opt embed references to generated files. The names of the generated files embed node id's, which will change depending on the content of the original source.
To guard against comparisons against stale output, check the timestamps of the supposed output against the timestamp of the original source (i.e. any output should be at least as new as the source that was recompiled).
Fix #39690.