-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version, upgrade bootstrap #39463
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Changes look good to me. |
LGTM to me as well. But we'll only know for sure once bors says its okay :) Little nit: |
aee924e
to
64280d2
Compare
@est31 removed! |
@bors r+ |
📌 Commit 64280d2 has been approved by |
Bump version, upgrade bootstrap This commit updates the version number to 1.17.0 as we're not on that version of the nightly compiler, and at the same time this updates src/stage0.txt to bootstrap from freshly minted beta compiler and beta Cargo.
💔 Test failed - status-travis |
64280d2
to
98f1d20
Compare
@bors: r=brson |
📌 Commit 98f1d20 has been approved by |
⌛ Testing commit 98f1d20 with merge 3386812... |
💔 Test failed - status-appveyor |
@bors: retry
|
⌛ Testing commit 98f1d20 with merge 7803f96... |
💔 Test failed - status-travis |
… On Fri, Feb 3, 2017 at 11:09 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/198104074>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39463 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95IfFATYNVNeSG3-Xgza0YTMvSxinks5rY3tbgaJpZM4L1dr9>
.
|
⌛ Testing commit 98f1d20 with merge 1d20da1... |
💔 Test failed - status-appveyor |
Hmm it seems like a spurious bug with Cargo. If code that created this error gets executed with itself in parallel, then it can in theory both times assume that dst exists, leading to the remove being attempted. One instance will then succeed, while the other instance will fail as the file was already removed. According to this playground example, attempting to non existent files leads in the NotFound error kind. Maybe ignore the error if that's the case? Either way, it looks like the error is spurious, so a retry should be attempted. |
This commit updates the version number to 1.17.0 as we're not on that version of the nightly compiler, and at the same time this updates src/stage0.txt to bootstrap from freshly minted beta compiler and beta Cargo.
98f1d20
to
626e754
Compare
📌 Commit 626e754 has been approved by |
Bump version, upgrade bootstrap This commit updates the version number to 1.17.0 as we're not on that version of the nightly compiler, and at the same time this updates src/stage0.txt to bootstrap from freshly minted beta compiler and beta Cargo.
☀️ Test successful - status-appveyor, status-travis |
This commit updates the version number to 1.17.0 as we're not on that version of
the nightly compiler, and at the same time this updates src/stage0.txt to
bootstrap from freshly minted beta compiler and beta Cargo.