Remove not(stage0) from deny(warnings) #38679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
Historically this was done to accommodate bugs in lints, but there hasn't been a bug in a lint since this feature was added which the warnings affected. Let's completely purge warnings from all our stages by denying warnings in all stages. This will also assist in tracking down `stage0` code to be removed whenever we're updating the bootstrap compiler.
alexcrichton
force-pushed
the
always-deny-warnings
branch
from
2677849 to
9b0b5b4
Compare
|
@bors: r+ |
|
📌 Commit 9b0b5b4 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 4, 2017
Remove not(stage0) from deny(warnings) Historically this was done to accommodate bugs in lints, but there hasn't been a bug in a lint since this feature was added which the warnings affected. Let's completely purge warnings from all our stages by denying warnings in all stages. This will also assist in tracking down `stage0` code to be removed whenever we're updating the bootstrap compiler.
|
💔 Test failed - status-travis |
|
@bors: retry
* llvm build wedged?
…On Tue, Jan 3, 2017 at 8:27 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/188739352>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38679 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Gdd5rQHG5TWdTTt13kWd-BBXXfjks5rOx_GgaJpZM4LXvTB>
.
|
|
⌛ Testing commit 9b0b5b4 with merge d115fd5... |
|
💔 Test failed - status-travis |
|
… On Wed, Jan 4, 2017 at 8:01 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189062201>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38679 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95OsGk5vVo1DuDf_Tfx-pym5MQVquks5rPGsFgaJpZM4LXvTB>
.
|
bors
added a commit
that referenced
this pull request
Jan 7, 2017
Remove not(stage0) from deny(warnings) Historically this was done to accommodate bugs in lints, but there hasn't been a bug in a lint since this feature was added which the warnings affected. Let's completely purge warnings from all our stages by denying warnings in all stages. This will also assist in tracking down `stage0` code to be removed whenever we're updating the bootstrap compiler.
|
💔 Test failed - status-appveyor |
|
@bors: retry
* timeout
…On Sat, Jan 7, 2017 at 10:03 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1444>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38679 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95FRDYtPCARGU9typSYfuT1gPItoaks5rP9OFgaJpZM4LXvTB>
.
|
bors
added a commit
that referenced
this pull request
Jan 8, 2017
Remove not(stage0) from deny(warnings) Historically this was done to accommodate bugs in lints, but there hasn't been a bug in a lint since this feature was added which the warnings affected. Let's completely purge warnings from all our stages by denying warnings in all stages. This will also assist in tracking down `stage0` code to be removed whenever we're updating the bootstrap compiler.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically this was done to accommodate bugs in lints, but there hasn't been a
bug in a lint since this feature was added which the warnings affected. Let's
completely purge warnings from all our stages by denying warnings in all stages.
This will also assist in tracking down
stage0code to be removed wheneverwe're updating the bootstrap compiler.