Emscripten targets are Unix targets #38598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
I don't know how the error got onto master. It seems like bors would have caught that. |
|
@bors r+ |
|
📌 Commit 31bda23 has been approved by |
|
Travis failed with some pretty relevant errors. |
|
Is there a possibility that it breaks code that does |
Just fixing a compile error
|
@bors: r+ p=1 |
|
📌 Commit f262eea has been approved by |
bors
added a commit
that referenced
this pull request
Dec 26, 2016
Emscripten targets are Unix targets I suspect this will fix the errors compiling libc https://buildbot.rust-lang.org/builders/auto-linux-rustbuild-cross-opt/builds/689/steps/compile/logs/stdio that are occurring on every PR. Emscripten is basically a posix emulation layer for the web and I consider it a Unix. cc @alexcrichton
Turns out we're not gating on the relevant builder in homu, we just haven't regressed it until now. Hurray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this will fix the errors compiling libc https://buildbot.rust-lang.org/builders/auto-linux-rustbuild-cross-opt/builds/689/steps/compile/logs/stdio that are occurring on every PR.
Emscripten is basically a posix emulation layer for the web and I consider it a Unix.
cc @alexcrichton