-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 29 pull requests #38499
Merged
Merged
Rollup of 29 pull requests #38499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For file ```rust use std::path::Path; fn f(p: Path) { } ``` provide the following error ```nocode error[E0277]: the trait bound `[u8]: std::marker::Sized` is not satisfied in `std::path::Path` --> file.rs:3:6 | 3 | fn f(p: Path) { } | ^ within `std::path::Path`, the trait `std::marker::Sized` is not implemented for `[u8]` | = note: `[u8]` does not have a constant size known at compile-time = note: required because it appears within the type `std::path::Path` = note: all local variables must have a statically known size ```
This makes it easier to work with mir test failures during development. - Show which expected line was not found - Show full expected output - Show full actual output
…d enums respectively.
After the fix of rust-lang#37453 in PR rust-lang#37369, instead of pointing at only the cast type, point at the full cast span when a cast needs a dereference: ``` error: casting `&{float}` as `f32` is invalid --> ../../../src/test/ui/mismatched_types/cast-rfc0401.rs:81:30 | 81 | vec![0.0].iter().map(|s| s as f32).collect::<Vec<f32>>(); | ^^^^^^^^ cannot cast `&{float}` as `f32` | help: did you mean `*s`? --> ../../../src/test/ui/mismatched_types/cast-rfc0401.rs:81:30 | 81 | vec![0.0].iter().map(|s| s as f32).collect::<Vec<f32>>(); | ^ ``` instead of ``` error: casting `&{float}` as `f32` is invalid --> ../../../src/test/ui/mismatched_types/cast-rfc0401.rs:81:35 | 81 | vec![0.0].iter().map(|s| s as f32).collect::<Vec<f32>>(); | - ^^^ | | | | | did you mean `*s`? | cannot cast `&{float}` as `f32` ```
They cause the search index from the std docs to get overwritten just like rust-lang#34800. Part of rust-lang#38319.
… into rollup Conflicts: src/librustc_trans/mir/mod.rs
…/rust into rollup Conflicts: src/librustc_resolve/lib.rs src/librustc_resolve/resolve_imports.rs
alexcrichton
force-pushed
the
rollup
branch
3 times, most recently
from
December 20, 2016 21:10
cd03fd3
to
4cb1206
Compare
☔ The latest upstream changes (presumably #38271) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors: r+ p=100 force |
📌 Commit d5f1c6e has been approved by |
bors
added a commit
that referenced
this pull request
Dec 20, 2016
Rollup of 29 pull requests - Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498 - Failed merges: #38271, #38483
This was referenced Dec 21, 2016
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt::Debug
for all structures in libstd. #38006, Add From<[u16; 8]> to Ipv6Addr #38131, Point out the known type when field doesn't satisfy bound #38150, Explain meaning of Result iters and link to factory functions #38158, Miscellaneous cleanup/refactoring inresolve
andsyntax::ext
#38171, Improvements toBTreeSet
documentation. #38208, minor fix about visibility in reference #38215, Unix socket doc #38236, When cast needs a dereference point at full cast #38245, A more verbose matching failure for mir tests #38289, Cleanup old trans #38302, Expand E0309 explanation with motivating example #38315, Duration doc #38346, Add prefix to config.toml #38388, rustdoc: a formatting nit #38395, rustbuild: Stop building docs for libtest by default #38398, Cleanup refactoring around DefPath handling #38418, Minor fix in the merge_sort comments #38432, adaptation to rustbuild for openbsd #38451, target spec: add an asm-args field to pass arguments to the external .. #38463, rustbuild: Eliminate duplication of dist tarballs #38468, rustbuild: Update Cargo download location #38470, rustbuild: Run debuginfo tests by default #38471, travis: Fix the cargotest bot #38472, Bump version to 1.16 #38478, Add regression test for #38458 #38486, Find FileCheck using llvm-config #38493, rustbuild: Actually test musl on the musl bot #38498legacy_imports
warnings #38271, small fix to closure debuginfo #38483