Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #37937

Merged
merged 16 commits into from
Nov 23, 2016
Merged

Rollup of 7 pull requests #37937

merged 16 commits into from
Nov 23, 2016

Conversation

steveklabnik and others added 6 commits November 17, 2016 13:16
The former wording only gave part of the picture, we want to be crystal
clear about this.
For a given code:

```rust
vec![0.0].iter().map(|s| s as i16).collect::<Vec<i16>>();
```

display:

```nocode
error: casting `&f64` as `i16` is invalid
 --> foo.rs:2:35
  |
2 |     vec![0.0].iter().map(|s| s as i16).collect::<Vec<i16>>();
  |                              -    ^^^ cannot cast `&f64` as `i16`
  |                              |
  |                              did you mean `*s`?
```

instead of:

```nocode
error: casting `&f64` as `i16` is invalid
 --> <anon>:2:30
  |
2 |     vec![0.0].iter().map(|s| s as i16).collect();
  |                              ^^^^^^^^
  |
  = help: cast through a raw pointer first
```
The change also adds the missing `SmallVec::truncate` method.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Nov 22, 2016

📌 Commit 3960357 has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Nov 22, 2016

⌛ Testing commit 3960357 with merge 89191c1...

@bors
Copy link
Contributor

bors commented Nov 22, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

…ndturner

Provide hint when cast needs a dereference

For a given code:

``` rust
vec![0.0].iter().map(|s| s as i16).collect::<Vec<i16>>();
```

display:

``` nocode
error: casting `&f64` as `i16` is invalid
 --> file3.rs:2:35
  |
2 |     vec![0.0].iter().map(|s| s as i16).collect::<Vec<i16>>();
  |                              -    ^^^
  |                              |
  |                              did you mean `*s`?
```

instead of:

``` nocode
error: casting `&f64` as `i16` is invalid
 --> <anon>:2:30
  |
2 |     vec![0.0].iter().map(|s| s as i16).collect();
  |                              ^^^^^^^^
  |
  = help: cast through a raw pointer first
```

Fixes rust-lang#37338.
… r=arielb1

Type walker small vector

These two changes avoid allocations on some hot paths and speed up a few workloads (some from rustc-benchmarks, as well as the workload from rust-lang#36799) by 1--2%.
…ence-comment, r=GuillaumeGomez

Clarify the reference's status.

The former wording only gave part of the picture, we want to be crystal
clear about this.

/cc @petrochenkov, who had concerns about rust-lang#37820
Add a regression test for issue 23699.

This should close rust-lang#23699
…eklabnik

Add some internal docs links for Args/ArgsOs

In many places the docs link to other sections and I noticed it was lacking here. Not sure if there is a standard for if inter-linking is appropriate.
…es, r=eddyb

Move the myriad-closures.rs test case to run-pass-full test suite.

r? @eddyb
…ctors, r=nikomatsakis

ICH: Add test case for struct constructor expressions.

r? @nikomatsakis
@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Nov 23, 2016

📌 Commit d2c600a has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Nov 23, 2016

⌛ Testing commit d2c600a with merge 127a83d...

bors added a commit that referenced this pull request Nov 23, 2016
Rollup of 7 pull requests

- Successful merges: #37442, #37760, #37836, #37851, #37859, #37913, #37925
- Failed merges:
@bors bors merged commit d2c600a into rust-lang:master Nov 23, 2016
@GuillaumeGomez GuillaumeGomez deleted the rollup branch November 23, 2016 20:12
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.