Default methods #3749
Closed
Default methods #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall this looks good to me. There are a few places where some more comments would be nice, as I requested above. Clearly more tests would be nice but we'll add them over time. r+ |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 8, 2024
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 8, 2024
…alfJung Detect when pthread_mutex_t is moved What I am not sure about this PR is how to support storing the additional mutex data like its address and kind. If I understand correctly the `concurrency::sync::Mutex` struct is to be used by any mutex implementation. This possibly means that different implementation might want to store different data in the mutex. So any additional data should be implementation defined somehow. Solutions that come to mind: - Store the additional data as `Box<dyn Any>` and the implementations can downcast their data when they fetch them. - Have each shim implementation define a `static mut` map between `MutexID`s and the additional data. Let me know Fixes rust-lang#3749
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 17, 2024
…fJung detect when pthread_rwlock_t is moved For some implementations of pthreads, the address of pthread_rwlock_t (or its fields) is used to identify the lock. That means that if the contents of a pthread_rwlock_t are moved in memory, effectively a new lock object is created, which is completely independted from the original. Thus we want to detect when when such objects are moved and show an error. see also rust-lang#3749 for more context
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 17, 2024
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 17, 2024
detect when pthread_cond_t is moved Closes rust-lang#3749
shrirambalaji
pushed a commit
to shrirambalaji/rust
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis