Improve "Doesn't live long enough" error #37405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiajt
reviewed
Oct 25, 2016
| 18 | } | ||
| | ^ `x` dropped here while still borrowed | ||
| | | ||
| note: borrowed value must be valid for the lifetime 'a as defined on the block at 16:30... |
There was a problem hiding this comment.
Ideally we want to move away from this kind of message and move towards showing them where that lifetime ends rather than them having to look up what 16:30 means and trying to figure it out.
Can we do this patch without touching these errors, or are they part of what needs to be updated for this PR?
|
|
@jonathandturner Is it ok? |
|
That looks good. @bors r+ |
|
📌 Commit b481a2d has been approved by |
|
☔ The latest upstream changes (presumably #37497) made this pull request unmergeable. Please resolve the merge conflicts. |
case with different lifetime with spans
|
@jonathandturner rebased |
|
@bors r+ |
|
📌 Commit a0e7e35 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Nov 2, 2016
Improve "Doesn't live long enough" error case with different lifetime scope issue rust-lang#36537 part of rust-lang#35233 r? @jonathandturner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case with different lifetime scope
issue #36537 part of #35233
r? @jonathandturner