Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid some allocations in the macro parser #37318

Merged
merged 3 commits into from
Oct 22, 2016
Merged

Avoid some allocations in the macro parser #37318

merged 3 commits into from
Oct 22, 2016

Commits on Oct 21, 2016

  1. Avoid an unnecessary clone in macro_parser::parse. 

    This avoids ~800,000 allocations in html5ever.
    @nnethercote
    nnethercote committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    a935481 View commit details
    Browse the repository at this point in the history

  2. Avoid an unnecessary clone in generic_extensions. 

    This avoids ~800,000 allocations in html5ever.
    @nnethercote
    nnethercote committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    e382267 View commit details
    Browse the repository at this point in the history

  3. Replace the String in ParseResult::Failure with Token. 

    This lets us delay creation of failure messages until they are needed,
which avoids ~1.6M allocations in html5ever.
    @nnethercote
    nnethercote committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    b817cf8 View commit details
    Browse the repository at this point in the history