Run rustfmt on libcore/sync folder #37218
Merged
+58
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
mattico
reviewed
Oct 16, 2016
| unsafe { atomic_store(self.v.get(), val as u8, order); } | ||
| unsafe { | ||
| atomic_store(self.v.get(), val as u8, order); | ||
| } |
There was a problem hiding this comment.
Hm, why does rustfmt put this on multiple lines...
mattico
reviewed
Oct 16, 2016
| unsafe { | ||
| atomic_load(self.p.get() as *mut usize, order) as *mut T | ||
| } | ||
| unsafe { atomic_load(self.p.get() as *mut usize, order) as *mut T } |
There was a problem hiding this comment.
...but this on a single line?
There was a problem hiding this comment.
Semicolon versus no semicolon? rustfmt appears to avoid ; }.
There was a problem hiding this comment.
Yeah, Rustfmt puts blocks which are expressions on one line, but not blocks of statements (even if just one)
|
@bors: r+ |
|
📌 Commit 5afd6d8 has been approved by |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Oct 19, 2016
Run rustfmt on libcore/sync folder
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Oct 19, 2016
Run rustfmt on libcore/sync folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.