Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more repos to cargotest #37149

Merged
merged 2 commits into from
Dec 30, 2016
Merged

Add some more repos to cargotest #37149

merged 2 commits into from
Dec 30, 2016

Conversation

edunham
Copy link
Member

@edunham edunham commented Oct 13, 2016

From suggestions at https://users.rust-lang.org/t/what-stable-rust-applications-do-you-use-frequently/7618

This adds some applications which use stable Rust and come with their own lockfiles in their respective trees.

ripgrep, xsv, and bins have 33 unique dependencies between them.

I alphabetized the list by project name because that seems tidier.

r? @brson

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 13, 2016

📌 Commit 4f71566 has been approved by alexcrichton

jonas-schievink
jonas-schievink reviewed Oct 13, 2016
View reviewed changes
src/tools/cargotest/main.rs
sha: "378da8f7d78df6e3ff0b234063de50619b16648e",
lock: None,
}
Test {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ewww tabs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, how embarrassing... Looks like circumventing my editor's insistence on 80-char lines also impeded its automatically fixing those. My apologies.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 31, 2016

📌 Commit 7d775e1 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 31, 2016

⌛ Testing commit 7d775e1 with merge 5a54b72...

@bors
Copy link
Contributor

bors commented Oct 31, 2016

💔 Test failed - auto-linux-64-cargotest

sanxiyn
sanxiyn reviewed Nov 7, 2016
View reviewed changes
src/tools/cargotest/main.rs
repo: "https://github.com/jkcclemens/bins",
sha: "378da8f7d78df6e3ff0b234063de50619b16648e",
lock: None,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma is missing here.

@edunham
Copy link
Member Author

edunham commented Nov 7, 2016

Sorry, I ought to have linted locally.

Fixed missing comma and rebased onto current master branch.

@sanxiyn
Copy link
Member

sanxiyn commented Nov 7, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Nov 7, 2016

📌 Commit 1e951ec has been approved by sanxiyn

@bors
Copy link
Contributor

bors commented Nov 7, 2016

⌛ Testing commit 1e951ec with merge d70463d...

@bors
Copy link
Contributor

bors commented Nov 7, 2016

💔 Test failed - auto-linux-cross-opt

@sanxiyn
Copy link
Member

sanxiyn commented Nov 8, 2016

@bors retry

crates.io outage.

@bors
Copy link
Contributor

bors commented Nov 8, 2016

⌛ Testing commit 1e951ec with merge fb54b2f...

@bors
Copy link
Contributor

bors commented Nov 8, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@sanxiyn
Copy link
Member

sanxiyn commented Nov 9, 2016

ripgrep failed two tests (symlink_follow, symlink_nofollow) on Windows.

@alexcrichton
Copy link
Member

cc @BurntSushi do you know of any tricks needed to get the ripgrep test suite passing on Windows? If it's too hard for the bots then we can perhaps just exclude the suite for now and add the other repos.

@BurntSushi
Copy link
Member

BurntSushi commented Nov 10, 2016 •
edited
Loading

@alexcrichton Oh interesting! Those tests pass on AppVeyor. However, there is at least one other test on Windows dealing with symlinks that I explicitly skip on Windows because it fails on AppVeyor for the same reason (permission error) symlink_follow and symlink_nofollow are failing on buildbot. The difference between the tests is that regression_137 uses a symlink to a file where as symlink_nofollow and symlink_follow use symlinks to directories. So directories work on AppVeyor but not files. Weird.

I don't think I did any tricks though. I'd be OK skipping them in ripgrep proper, because symlinks on Windows are pretty janky anyway. Other ideas?

@alexcrichton
Copy link
Member

I do recall there's some Windows permission to allow users to create symlinks, so maybe appveyor has that enabled by default? (our buildbots don't).

But yeah if you want to skip these in the ripgrep test suite we could update to include that!

BurntSushi added a commit to BurntSushi/ripgrep that referenced this pull request Nov 11, 2016
@BurntSushi
Disable symlink tests on Windows.
4b18f82 
For some reason, these work on AppVeyor but not in other build systems.
Let's just disable them.

See: rust-lang/rust#37149
@BurntSushi
Copy link
Member

OK, I disabled the tests, which should take effect in the next release.

@alexcrichton
Copy link
Member

Awesome, thanks @BurntSushi! @edunham want to update git git repo for ripgrep and we can retry?

@bors
Copy link
Contributor

bors commented Dec 29, 2016

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Dec 29, 2016 via email

@bors
Copy link
Contributor

bors commented Dec 29, 2016

⌛ Testing commit a0f3c93 with merge 9c145c2...

@bors
Copy link
Contributor

bors commented Dec 29, 2016

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Dec 29, 2016 via email

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
@alexcrichton
Rollup merge of rust-lang#37149 - edunham:more-cargotest, r=alexcrichton
2293ea5 
Add some more repos to cargotest

From suggestions at https://users.rust-lang.org/t/what-stable-rust-applications-do-you-use-frequently/7618

This adds some applications which use stable Rust and come with their own lockfiles in their respective trees.

ripgrep, xsv, and bins have 33 unique dependencies between them.

I alphabetized the list by project name because that seems tidier.

r? @brson
@alexcrichton alexcrichton mentioned this pull request Dec 30, 2016
Merged
@bors
Copy link
Contributor

bors commented Dec 30, 2016

⌛ Testing commit a0f3c93 with merge 1ac816c...

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Dec 30, 2016

⌛ Testing commit a0f3c93 with merge 738e016...

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Dec 30, 2016

⌛ Testing commit a0f3c93 with merge b8af359...

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Dec 30, 2016

⌛ Testing commit a0f3c93 with merge 42d4de0...

@bors
Copy link
Contributor

bors commented Dec 30, 2016

💔 Test failed - status-travis

bors added a commit that referenced this pull request Dec 30, 2016
@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton
7f2d2af 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
@bors bors merged commit a0f3c93 into rust-lang:master Dec 30, 2016
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
@alexcrichton
cargotest: Add xsv to tested crates
73b708a 
This was intended to land in rust-lang#37149 but I ended up backing it out to land the
rollup (rust-lang#38697) last night as I was itching to do so. This morning though xsv
has been fixed now (BurntSushi/xsv#53) so we should be able to add it!
@alexcrichton alexcrichton mentioned this pull request Dec 30, 2016
Merged
bors added a commit that referenced this pull request Dec 31, 2016
@bors
Auto merge of #38709 - alexcrichton:check-xsv, r=nikomatsakis
ca0cc27 
cargotest: Add xsv to tested crates

This was intended to land in #37149 but I ended up backing it out to land the
rollup (#38697) last night as I was itching to do so. This morning though xsv
has been fixed now (BurntSushi/xsv#53) so we should be able to add it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

@sanxiyn sanxiyn sanxiyn left review comments

Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@edunham @rust-highfive @alexcrichton @bors @sanxiyn @BurntSushi @arielb1 @jonas-schievink @brson