Implement std::str::replacen #36347
Implement std::str::replacen #36347
Conversation
|
It's rare that @rust-highfive didn't show up 😮 |
src/libcollections/str.rs
Outdated
There was a problem hiding this comment.
Insta-stable? AFAICT there’s no tracking issue which went through FCP for stabilisation?
There was a problem hiding this comment.
@nagisa I'm sorry... Should I submit a RFC about this? BTW, where can I know the process of accepting a new method?
There was a problem hiding this comment.
An unstable method with a corresponding tracking issue may be enough.
There was a problem hiding this comment.
@nagisa Am I supposed to open the tracking issue by myself?
There was a problem hiding this comment.
I’d suggest to only do that after you get thumbs-up from the libs team for the feature you’re adding. In the mean-time you can use 0 as a placeholder issue for the attribute.
|
This PR needs a reviewer, @rust-lang/libs. |
knight42
force-pushed
the
str-replacen
branch
from
e89edb9 to
f89f3a0
Compare
|
@nagisa Thanks for your advice! 😄 |
|
Seems quite niche to me. |
knight42
force-pushed
the
str-replacen
branch
from
f89f3a0 to
1b65a57
Compare
src/libcollections/str.rs
Outdated
There was a problem hiding this comment.
Using .take(count) would be the more typical way to limit the number of iterations here. (I'd understand it right away :D)
knight42
force-pushed
the
str-replacen
branch
from
1b65a57 to
2b95aab
Compare
alexcrichton
added
the
T-libs-api
|
Discussed at libs triage today the decision was to merge. @knight42 could you open an issue on rust-lang/rust to track the stabilization of this and update the |
knight42
force-pushed
the
str-replacen
branch
from
2b95aab to
ebda770
Compare
|
@alexcrichton Great to hear that! 🎉 The |
|
@bors: r+ Thanks! |
|
📌 Commit ebda770 has been approved by |
|
⌛ Testing commit ebda770 with merge e25e32c... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@alexcrichton the failure seems spurious |
|
@bors: retry On Tue, Sep 13, 2016 at 8:59 PM, Jian Zeng [email protected] wrote:
|
Implement std::str::replacen
Replaces first N matches of a pattern with another string.
```
assert_eq!("acaaa".replacen(a, "b", 3), "bcbba")
```
7 participants
Replaces first N matches of a pattern with another string.