-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed E0528 label and unit test #36205
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@jonathandturner this is ready for review. Travis-CI failed because of #36138. |
Looks good. @bors r+ rollup |
📌 Commit 7cd4e7f has been approved by |
…rner Fixed E0528 label and unit test Fixes rust-lang#36194 part of rust-lang#35233. r? @jonathandturner
…rner Fixed E0528 label and unit test Fixes rust-lang#36194 part of rust-lang#35233. r? @jonathandturner
…rner Fixed E0528 label and unit test Fixes rust-lang#36194 part of rust-lang#35233. r? @jonathandturner
Fixes #36194 part of #35233.
r? @jonathandturner