Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0453 to new error format #35989

Merged
merged 1 commit into from
Aug 28, 2016
Merged

Conversation

0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Aug 25, 2016

Fixes #35929.
Part of #35233.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2016

📌 Commit dc5bb80 has been approved by jonathandturner

@sophiajt
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2016

📌 Commit feeae00 has been approved by jonathandturner

@sophiajt
Copy link
Contributor

@bors r-

I'll stop approving while you work ;) Just ping me again when you're ready. If you would, please squash the PRs.

@0xmohit 0xmohit force-pushed the pr/error-code-E0453 branch from ccaafee to e4871c4 Compare August 25, 2016 19:13
@0xmohit
Copy link
Contributor Author

0xmohit commented Aug 25, 2016

@jonathandturner Done. Moral of the story: always test before submitting a PR ;)

@sophiajt
Copy link
Contributor

@0xmohit - I've learned that one... many times ;)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2016

📌 Commit e4871c4 has been approved by jonathandturner

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 25, 2016
@0xmohit
Copy link
Contributor Author

0xmohit commented Aug 26, 2016

The failure appears due to a test in src/test/compile-fail-fulldeps/. Figuring.

@sophiajt
Copy link
Contributor

For those I think you may need to test against check-cfail-full. Possibly at stage 2

@0xmohit 0xmohit force-pushed the pr/error-code-E0453 branch from d6e8561 to 88e4def Compare August 26, 2016 02:31
@0xmohit
Copy link
Contributor Author

0xmohit commented Aug 26, 2016

Tested against both check-cfail and check-cfail-full; things seem to be ok. PTAL.

@sophiajt
Copy link
Contributor

Great. Let's give it a try.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 26, 2016

📌 Commit 88e4def has been approved by jonathandturner

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 27, 2016
bors added a commit that referenced this pull request Aug 27, 2016
Rollup of 6 pull requests

- Successful merges: #35657, #35980, #35985, #35989, #36003, #36044
- Failed merges:
@bors bors merged commit 88e4def into rust-lang:master Aug 28, 2016
@0xmohit 0xmohit deleted the pr/error-code-E0453 branch August 29, 2016 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants