-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E0453 to new error format #35989
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Looks good! @bors r+ rollup |
📌 Commit dc5bb80 has been approved by |
@bors r+ rollup |
📌 Commit feeae00 has been approved by |
@bors r- I'll stop approving while you work ;) Just ping me again when you're ready. If you would, please squash the PRs. |
ccaafee
to
e4871c4
Compare
@jonathandturner Done. Moral of the story: always test before submitting a PR ;) |
📌 Commit e4871c4 has been approved by |
…thandturner Update E0453 to new error format Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
The failure appears due to a test in src/test/compile-fail-fulldeps/. Figuring. |
For those I think you may need to test against check-cfail-full. Possibly at stage 2 |
Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
d6e8561
to
88e4def
Compare
Tested against both |
Great. Let's give it a try. @bors r+ rollup |
📌 Commit 88e4def has been approved by |
…thandturner Update E0453 to new error format Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
…thandturner Update E0453 to new error format Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
Fixes #35929.
Part of #35233.
r? @jonathandturner