add links to interesting items in std::ptr documentation
#35880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -224,15 +224,17 @@ extern "rust-intrinsic" { | |||
| /// trait objects, because they can't be read out onto the stack and | |||
| /// dropped normally. | |||
| /// | |||
| /// * It is friendlier to the optimizer to do this over `ptr::read` when | |||
| /// * It is friendlier to the optimizer to do this over [`ptr::read`] when | |||
| /// dropping manually allocated memory (e.g. when writing Box/Rc/Vec), | |||
There was a problem hiding this comment.
Can you add urls for Box, Rc and Vec as well please? (If you really don't want to, I won't bother you with it.)
matthew-piziak
force-pushed
the
ptr-linking
branch
from
d9530c4 to
33560ee
Compare
|
@bors: r+ rollup |
|
📌 Commit 33560ee has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 25, 2016
…klabnik add links to interesting items in `std::ptr` documentation r? @steveklabnik
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 26, 2016
…klabnik add links to interesting items in `std::ptr` documentation r? @steveklabnik
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 26, 2016
…klabnik add links to interesting items in `std::ptr` documentation r? @steveklabnik
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 27, 2016
…klabnik add links to interesting items in `std::ptr` documentation r? @steveklabnik
|
Broken: std\ptr\fn.read.html:59: broken link - std\ptr\fn.zero_memory.html
std\ptr\fn.read.html:59: broken link - std\ptr\fn.copy_memory.html
std\ptr\fn.read_volatile.html:69: broken link - std\ptr\fn.zero_memory.html
std\ptr\fn.read_volatile.html:69: broken link - std\ptr\fn.copy_memory.html(and some others) @bors: r- |
|
@GuillaumeGomez What is the correct command to reproduce this breakage? I cannot reproduce with |
cd src/tools/linkchecker
cargo run ../../lib_you_want_to_check |
|
Have |
|
Check on nigthly docs. |
|
@GuillaumeGomez I tried that. I'd expect to see them here: https://doc.rust-lang.org/nightly/std/mem/ |
|
These two functions have been removed it seems, indeed. |
|
Travis looks spurious, let's try with bors. @bors: r+ rollup |
|
📌 Commit b5ce02c has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…klabnik add links to interesting items in `std::ptr` documentation Part of rust-lang#29371. r? @steveklabnik
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…klabnik add links to interesting items in `std::ptr` documentation Part of rust-lang#29371. r? @steveklabnik
|
@bors r- Looks like there some breakages on x86_64-unknown-linux-gnu |
matthew-piziak
force-pushed
the
ptr-linking
branch
from
e3bc6bd to
e0e7b7e
Compare
matthew-piziak
force-pushed
the
ptr-linking
branch
from
e0e7b7e to
60b799a
Compare
|
Failed: core/intrinsics/fn.drop_in_place.html:59: broken link - core/intrinsics/fn.read.html
core/intrinsics/fn.drop_in_place.html:61: broken link - core/boxed/struct.Box.html
core/intrinsics/fn.drop_in_place.html:61: broken link - core/rc/struct.Rc.html
core/intrinsics/fn.drop_in_place.html:61: broken link - core/vec/struct.Vec.html
core/intrinsics/fn.drop_in_place.html:66: broken link - core/intrinsics/fn.read.html
std/intrinsics/fn.drop_in_place.html:59: broken link - std/intrinsics/fn.read.html
std/intrinsics/fn.drop_in_place.html:66: broken link - std/intrinsics/fn.read.html
thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:54 |
|
@matthew-piziak ping! still keeping up with this? |
|
@steveklabnik Sorry, I've been traveling for the past three weeks. I should be back in the game around 7 October. Right now this PR is soft-blocking on #36417. Feel free to close; I'll keep the branch alive on my fork. |
|
Same as in the other thread, no worries, safe travels, let's close for now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29371.
r? @steveklabnik