replace AddAssign example with something more evocative of addition
#35806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| /// *self = Point { | ||
| /// x: self.x + other.x, | ||
| /// y: self.y + other.y, | ||
| /// } |
There was a problem hiding this comment.
while this doesn't require a ; here, I would put one.
This is analogous to PR rust-lang#35709 for the `Add` trait.
matthew-piziak
force-pushed
the
addassign-example
branch
from
41125f0 to
6c66eaa
Compare
|
@bors: r+ rollup |
|
📌 Commit 6c66eaa has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 18, 2016
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 19, 2016
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 19, 2016
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 20, 2016
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 20, 2016
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
bors
added a commit
that referenced
this pull request
Aug 20, 2016
matthew-piziak
added a commit
to matthew-piziak/rust
that referenced
this pull request
Aug 22, 2016
These examples are exactly analogous to those in PRs rust-lang#35709 and rust-lang#35806. I'll probably remove the `fn main` wrappers for `Add` and `Sub` once this is merged in. Part of rust-lang#29365. r? @steveklabnik
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 24, 2016
…laumeGomez more evocative examples for `Sub` and `SubAssign` These examples are exactly analogous to those in PRs rust-lang#35709 and rust-lang#35806. I'll probably remove the `fn main` wrappers for `Add` and `Sub` once this is merged in. Part of rust-lang#29365. r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is analogous to PR #35709 for the
Addtrait.