-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label to E0254 #35596
Add label to E0254 #35596
Conversation
This issue #35513 is a part of #35233. r? @jonathandturner
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Great, almost there. You'll need to run this through tidy and fix the errors. After that, it looks like it's ready:
|
Great! @bors r+ rollup |
📌 Commit c761184 has been approved by |
…ts, r=jonathandturner Add label to E0254 This issue rust-lang#35513 is a part of rust-lang#35233. r? @jonathandturner
…ts, r=jonathandturner Add label to E0254 This issue rust-lang#35513 is a part of rust-lang#35233. r? @jonathandturner
…ts, r=jonathandturner Add label to E0254 This issue rust-lang#35513 is a part of rust-lang#35233. r? @jonathandturner
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
This issue #35513 is a part of #35233.
r? @jonathandturner