Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0248, E0267 & E0268 New Format #35475

Closed
wants to merge 13 commits into from
Closed

E0248, E0267 & E0268 New Format #35475

wants to merge 13 commits into from

Conversation

shyamsundarb-arch
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shyamsundarb-arch
Copy link
Contributor Author

@jonathandturner Hi. I tried a fresh commit. I am unable to merge to file changes into a single commit. Kindly let me know if this is ok!

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

@shyaamsundhar - that's okay, it can be tricky getting used to the tools.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit a848f11 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35475 - shyaamsundhar:patch-1, r=jonathandt…
09e2e04 
…urner

E0248 New Format
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Closed
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of #35476 - jonathandturner:rollup, r=jonathandturner
8913330 
Rollup of 6 pull requests

- Successful merges: #35396, #35402, #35446, #35466, #35470, #35475
- Failed merges: #35395, #35415
@bors
Copy link
Contributor

bors commented Aug 8, 2016

⌛ Testing commit a848f11 with merge 0bab238...

@bors
Copy link
Contributor

bors commented Aug 8, 2016

💔 Test failed - auto-win-gnu-64-opt

@shyamsundarb-arch
Copy link
Contributor Author

@jonathandturner Hi, I am unable to understand this error. Can you help pls?

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

Looks like the server that tests each build is having problems. Looking into it...

@alexcrichton
Copy link
Member

@bors: retry

  • not sure why...

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
Rollup merge of rust-lang#35475 - shyaamsundhar:patch-1, r=jonathandt…
bbbac59 
…urner

E0248 New Format
@sophiajt sophiajt mentioned this pull request Aug 8, 2016
Merged
@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

@shyaamsundhar - Thanks for adding both to the same PR. A couple things, and I think we'll be ready:

  1. Update the title of the PR to show both error codes being fixed
  2. Squash the 5 commits down to 1 commit

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

@bors r-

Pulling it out of bors to give @shyaamsundhar time to do the fixes

@shyamsundarb-arch shyamsundarb-arch changed the title E0248 New Format E0248, E0267 & E0268 New Format Aug 9, 2016
@shyamsundarb-arch
E0248 Change in issue format
1a6fac7 
E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
@shyamsundarb-arch
Merge branch 'patch-1' of https://github.com/shyaamsundhar/rust into …
fc06f3c 
…patch-1
bors added a commit that referenced this pull request Aug 10, 2016
@bors
Auto merge of #35525 - jonathandturner:rollup, r=jonathandturner
1f2ae38 
Rollup of 15 pull requests

- Successful merges: #35371, #35396, #35446, #35449, #35452, #35458, #35465, #35466, #35470, #35475, #35477, #35484, #35504, #35507, #35524
- Failed merges: #35395, #35415
@shyamsundarb-arch
Revert "E0248 Change in issue format"
9a3c119 
This reverts commit a848f11.
@shyamsundarb-arch
Revert "E0248 Change in issue format"
6ac944e 
This reverts commit 4a99a9d.
@shyamsundarb-arch
E0248 Change in issue format
b0f5f9b 
E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
@shyamsundarb-arch
Copy link
Contributor Author

Have squashed into single commit in pull request #35586. So closing this pull request.

@shyamsundarb-arch shyamsundarb-arch deleted the patch-1 branch August 11, 2016 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shyamsundarb-arch @rust-highfive @sophiajt @bors @alexcrichton @arielb1