Updates compiler error E0046 with new format #35355
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the PR! You'll need to also update the unit tests in the src/test directory that test this error: |
|
Oh damn, I thought I ran the unit test scripts too which showed no failed tests. I'll get to this when I get home tonight. Thank you for showing it in snippets. |
|
Hopefully, I've covered all the test files that mentions this error. |
|
Looks good! @bors r+ rollup |
|
📌 Commit 9f09ee5 has been approved by |
Updates compiler error E0046 with new format Addresses rust-lang#35209 as part of rust-lang#35233. r? @jonathandturner I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you. ```rust missing_items.iter() .map(|name| name.to_string()) .collect::<Vec<_>>().join("`, `")) ```
| @@ -14,7 +14,9 @@ trait Foo { | |||
|
|
|||
| struct Bar; | |||
|
|
|||
| impl Foo for Bar {} //~ ERROR E0046 | |||
| impl Foo for Bar {} | |||
There was a problem hiding this comment.
Trailing whitespace on this line.
|
@bors r- |
|
@bors r+ rollup |
|
📌 Commit ed72c65 has been approved by |
Updates compiler error E0046 with new format Addresses rust-lang#35209 as part of rust-lang#35233. r? @jonathandturner I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you. ```rust missing_items.iter() .map(|name| name.to_string()) .collect::<Vec<_>>().join("`, `")) ```
Updates compiler error E0046 with new format Addresses rust-lang#35209 as part of rust-lang#35233. r? @jonathandturner I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you. ```rust missing_items.iter() .map(|name| name.to_string()) .collect::<Vec<_>>().join("`, `")) ```
Addresses #35209 as part of #35233.
r? @jonathandturner
I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you.