Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "x86-64" as the target CPU for NetBSD and Bitrig on amd64. #35033

Merged
merged 2 commits into from
Aug 1, 2016

Conversation

jakllsch
Copy link
Contributor

Using "generic" disables a number of features that are present on all
x86_64 cpus, the "x86-64" target cpu is the common denominator for that
arch.

Refs #20777

Using "generic" disables a number of features that are present on all
x86_64 cpus, the "x86-64" target cpu is the common denominator for that
arch.

Refs rust-lang#20777
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! I'm curious though, why not do this for all targets?

@jakllsch
Copy link
Contributor Author

"All"? As far as I can tell it's already been done for every other x86_64-based system. The Apple ones use "core2" instead of "x86-64". On NetBSD there's a SSE-related test case failure this fixes because LLVM uses the generic lowest-common-denominator x86 instead of x86_64 which inherently has SSE2.

@nagisa
Copy link
Member

nagisa commented Jul 26, 2016

I feel like it is a bug in LLVM that generic for x86_64 is not x86_64, but otherwise I’m not opposed to this PR.

@alexcrichton
Copy link
Member

@bors: r+ 1f86005

Ah ok, thanks! I didn't realize we'd already done this for other targets, and sounds like good motivation to me.

@eddyb
Copy link
Member

eddyb commented Aug 1, 2016

@bors r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Aug 1, 2016

📌 Commit 990f193 has been approved by alexcrichton

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Aug 1, 2016
…excrichton

Use "x86-64" as the target CPU for NetBSD and Bitrig on amd64.

Using "generic" disables a number of features that are present on all
x86_64 cpus, the "x86-64" target cpu is the common denominator for that
arch.

Refs rust-lang#20777
bors added a commit that referenced this pull request Aug 1, 2016
Rollup of 8 pull requests

- Successful merges: #34802, #35033, #35085, #35114, #35134, #35140, #35141, #35157
- Failed merges:
@bors bors merged commit 990f193 into rust-lang:master Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants