Add regression tests for #13727. #34003
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
force-pushed
the
13727-regressions
branch
from
745eeaf to
fa180b9
Compare
|
Seems like src/test/compile-fail/issue-13727-2.rs must be covered elsewhere in the test suite. The other test looks fine since it captures what the compiler actually does. But is this the behavior we would actually expect from match patterns that are out of range? Do we actually guarantee that integers wrap at compile time (when we don't at runtime)? |
|
The first one may be covered by |
|
It's also covered issue-15524. Can you remove the redundant test? r=me otherwise. |
frewsxcv
force-pushed
the
13727-regressions
branch
from
fa180b9 to
7755d0c
Compare
Done. |
|
@bors r+ |
|
📌 Commit 7755d0c has been approved by |
Fixes #13727.