Implement Error trait for fmt::Error type #33856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -212,6 +212,13 @@ impl<T: Error> Error for Box<T> { | |||
| } | |||
| } | |||
|
|
|||
| #[unstable(feature = "fmt_error", issue = "33827")] | |||
There was a problem hiding this comment.
Unfortunately we don't actually read stability attributes on impl blocks for traits, so this'll be "insta-stable". It's fine to just change this to #[stable]
|
Ok, now it's stable. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 28, 2016
…chton Implement Error trait for fmt::Error type Fixes rust-lang#33827. r? @alexcrichton Just one last thing: I added a feature name, but don't hesitate to ask me to change it if you think it doesn't fit well.
bors
added a commit
that referenced
this pull request
May 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33827.
r? @alexcrichton
Just one last thing: I added a feature name, but don't hesitate to ask me to change it if you think it doesn't fit well.