-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement fuzzy matching in on_unimplemented #33694
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// Test if the on_unimplemented message override works | ||
|
||
#![feature(on_unimplemented)] | ||
#![feature(rustc_attrs)] | ||
|
||
struct Foo<T>(T); | ||
struct Bar<T>(T); | ||
|
||
#[rustc_on_unimplemented = "trait message"] | ||
trait Index<Idx: ?Sized> { | ||
type Output: ?Sized; | ||
fn index(&self, index: Idx) -> &Self::Output; | ||
} | ||
|
||
#[rustc_on_unimplemented = "on impl for Foo"] | ||
impl Index<Foo<usize>> for [i32] { | ||
type Output = i32; | ||
fn index(&self, _index: Foo<usize>) -> &i32 { | ||
loop {} | ||
} | ||
} | ||
|
||
#[rustc_on_unimplemented = "on impl for Bar"] | ||
impl Index<Bar<usize>> for [i32] { | ||
type Output = i32; | ||
fn index(&self, _index: Bar<usize>) -> &i32 { | ||
loop {} | ||
} | ||
} | ||
|
||
#[rustc_error] | ||
fn main() { | ||
Index::index(&[] as &[i32], 2u32); | ||
//~^ ERROR E0277 | ||
//~| NOTE trait message | ||
//~| NOTE required by | ||
Index::index(&[] as &[i32], Foo(2u32)); | ||
//~^ ERROR E0277 | ||
//~| NOTE on impl for Foo | ||
//~| NOTE required by | ||
Index::index(&[] as &[i32], Bar(2u32)); | ||
//~^ ERROR E0277 | ||
//~| NOTE on impl for Bar | ||
//~| NOTE required by | ||
} |
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
usize