Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings for Issue 32330 #33105

Closed
wants to merge 10 commits into from
Closed

Warnings for Issue 32330 #33105

wants to merge 10 commits into from

Commits on Apr 20, 2016

  1. add LateBoundRegionsCollector

    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    c8b2d18 View commit details
    Browse the repository at this point in the history

  2. Error for where-clause with unconstrained late-bound lifetimes

    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    4bfef5c View commit details
    Browse the repository at this point in the history

  3. warn if bindings/return-types reference regions 

    This is a step towards fixing rust-lang#32330. The full fix would be a breaking
change, so we begin by issuing warnings for scenarios that will break.
    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    d05a49c View commit details
    Browse the repository at this point in the history

  4. refine the warnings to consider projection inputs

    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    4aeadfa View commit details
    Browse the repository at this point in the history

  5. refactor: use select inside of a probe 

    We ought not to be affecting inference state when assembling candidates,
so invoke select inside of a probe.
    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    a03707d View commit details
    Browse the repository at this point in the history

  6. no candidate for impl with default type 

    Before we would ignore a candidate if it happened to be an impl with a
default type. This change makes us never add the impl in the first
place. This seems largely equivalent, though there might be some subtle
difference in that -- before -- we would have failed to normalize if
there was a "trait-def-candidate" contending with an (opaque) impl
candidate. This corresponds I guess to a case like `<<A as Trait>::B as
Trait2>::C`, and the definition of `Trait` contains a clause. Pretty
obscure, but it seems like it's... ok to favor the trait definition in
such a case.
    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    c3c80aa View commit details
    Browse the repository at this point in the history

  7. fix error message

    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    a9ffef8 View commit details
    Browse the repository at this point in the history

  8. add flag for ReSkolemized

    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    beae6c7 View commit details
    Browse the repository at this point in the history

  9. fix stale method names

    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    cf12a79 View commit details
    Browse the repository at this point in the history

  10. fix minor rebase artifacts

    @nikomatsakis
    nikomatsakis committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    3449575 View commit details
    Browse the repository at this point in the history